Don't add -l prefix if it already exists. #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brawner
reviewed
Dec 20, 2018
| @@ -100,7 +100,7 @@ def __init__(self): | |||
|
|
|||
|
|
|||
| def custom_platform_lib_function(self, clib, framework=0): | |||
| if os.path.isabs(clib): | |||
| if os.path.isabs(clib) or clib.startswith('-l'): | |||
There was a problem hiding this comment.
Please add a comment describing why this check is necessary and libraries that already append -l
hgaiser
force-pushed
the
libraries-prefix
branch
from
943e8a0
to
e4eed9b
Compare
|
Apologies for the delay, holidays and everything. I just pushed the requested change. |
|
Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly as discussed here, a
-lshouldn't be prefixed if a library already has a-lprefix. Recently (cmake 3.13) exported its dependency on pthread by adding-lpthreadto${Boost_LIBRARIES}. Using thesip_helper.pyon cmake 3.13 gives the following error: